Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements: update urllib3 to 1.24.2 #10512

Merged
merged 1 commit into from
May 13, 2019
Merged

requirements: update urllib3 to 1.24.2 #10512

merged 1 commit into from
May 13, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Apr 30, 2019 •
edited
Loading

Description

Reported on Github as vulnerability, Reference: CVE-2019-11324. As we used specific version, I kept this one as well.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@cmonr

Release Notes

@ciarmcom ciarmcom requested review from cmonr and a team April 30, 2019 11:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@cmonr @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor Author

0xc0170 commented May 2, 2019

CI started

@cmonr cmonr mentioned this pull request May 3, 2019
Closed
@adbridge
Copy link
Contributor

adbridge commented May 7, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 7, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor Author

0xc0170 commented May 10, 2019

CI restarted

@bulislaw
Copy link
Member

bulislaw commented May 10, 2019 •
edited
Loading

Question: Why 1.24.2 and not 1.24(.*)? Never mind, figured it out.

@mbed-ci
Copy link

mbed-ci commented May 10, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor Author

0xc0170 commented May 12, 2019

Exporters restarted

@0xc0170 0xc0170 merged commit 35db06e into ARMmbed:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xc0170 @ciarmcom @adbridge @mbed-ci @bulislaw @cmonr